Added binary shifts and twos complement functions to bit manipulation #4068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
awaiting reviews
ghost
reviewed
Dec 27, 2020
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
bit_manipulation/binary_shifts.py
Outdated
| from binary_twos_complement import twos_complement | ||
|
|
||
|
|
||
| def logical_left_shift(a: int, b: int) -> str: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
bit_manipulation/binary_shifts.py
Outdated
| return binary_a | ||
|
|
||
|
|
||
| def logical_right_shift(a: int, b: int) -> str: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
bit_manipulation/binary_shifts.py
Outdated
| return '0b' + shifted_binary_a | ||
|
|
||
|
|
||
| def arithmetic_right_shift(a: int, b: int) -> str: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
| @@ -0,0 +1,33 @@ | |||
| def twos_complement(a: int) -> str: | |||
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
ghost
removed
the
require descriptive names
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
dhruvmanila
approved these changes
Feb 23, 2021
peRFectBeliever
pushed a commit
to peRFectBeliever/Python
that referenced
this pull request
Apr 1, 2021
…TheAlgorithms#4068) * Added binary shifts and twos complement functions to bit manipulation package * Fixed problem representing 0 wrong * More testing * Fixed problems * Fixed formatting * More format fixes * Format fixes * Fixed docstrings and added url * Minor change to url
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
…TheAlgorithms#4068) * Added binary shifts and twos complement functions to bit manipulation package * Fixed problem representing 0 wrong * More testing * Fixed problems * Fixed formatting * More format fixes * Format fixes * Fixed docstrings and added url * Minor change to url
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
…TheAlgorithms#4068) * Added binary shifts and twos complement functions to bit manipulation package * Fixed problem representing 0 wrong * More testing * Fixed problems * Fixed formatting * More format fixes * Format fixes * Fixed docstrings and added url * Minor change to url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… package
Describe your change:
Added binary shifts (left logical, right logical, right arithmetic) and two's complement functions to bit manipulation package. Added both since used 2's complement in the shifts.
Checklist:
Fixes: #{$ISSUE_NO}.